Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installer improvements #275

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Installer improvements #275

merged 4 commits into from
Sep 27, 2024

Conversation

jakub-kocka
Copy link
Collaborator

@jakub-kocka jakub-kocka commented Sep 13, 2024 •
edited
Loading

  • Fixed Action for installer build - the IDE installer type
  • Added OS version check and note for the users
  • Added option to open the documentation after completed installation
    • online installer opens the ESP-IDF website
    • offline installer has the ESP-IDF documentation bundled and opens the PDF
  • Added successful installation check
    • Fixes unwanted opening of the system directory if the installation fails
  • Updated IDF-ENV version because of the migration of the drivers to our server
image

Related

  • Internal tracker for the IDE installer fix: IDF-10094
  • Installer improvements internal tracker: IDF-10040

@jakub-kocka
fix(docs_update_script): Fixed IDE Installer version
bbbc2f2
@jakub-kocka
feat: Added a OS version check and prompt when unsupported
9518b84 
This feature has already been present in system check, now the message box was added to stress the note for users.
@jakub-kocka jakub-kocka self-assigned this Sep 13, 2024
@jakub-kocka jakub-kocka changed the title Installer improvements Draft: Installer improvements Sep 13, 2024
@jakub-kocka jakub-kocka marked this pull request as draft September 13, 2024 14:03
@jakub-kocka jakub-kocka marked this pull request as ready for review September 17, 2024 12:34
@jakub-kocka jakub-kocka changed the title Draft: Installer improvements Installer improvements Sep 17, 2024
@jakub-kocka
Copy link
Collaborator Author

PTAL, @dobairoland when you have time.

dobairoland
dobairoland approved these changes Sep 23, 2024
View reviewed changes
Copy link

@dobairoland dobairoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakub-kocka
Copy link
Collaborator Author

Based on in-person discussions we agreed to merge this with the PDF documentation support for now. We can change the implementation as soon as the HTML package generation of docs is ready and stable.

So I am merging this, thanks for the review.

@jakub-kocka jakub-kocka merged commit b8576f5 into main Sep 27, 2024
4 checks passed
@jakub-kocka jakub-kocka deleted the installer_improvements branch September 27, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dobairoland dobairoland dobairoland approved these changes

@georgik georgik Awaiting requested review from georgik

Assignees

@jakub-kocka jakub-kocka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakub-kocka @dobairoland