Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed offline documentation download URL #281

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

jakub-kocka
Copy link
Collaborator

Description

  • The URL for the PDF download was fixed to be dynamically generated for the branches

Related

Failing build: https://github.com/espressif/idf-installer/actions/runs/11214102858

Testing

Fixed build: https://github.com/espressif/idf-installer/actions/runs/11214781512/job/31170576041

@jakub-kocka jakub-kocka self-assigned this Oct 7, 2024
Copy link

@peterdragun peterdragun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakub-kocka
Copy link
Collaborator Author

Thank you, for the review. I am merging this.

@jakub-kocka jakub-kocka merged commit db09a88 into main Oct 7, 2024
4 checks passed
@jakub-kocka jakub-kocka deleted the fix/offline_documentation_download branch October 7, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants