Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add symbol and footprint for ESP32-DevKitM-1 #163

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Add symbol and footprint for ESP32-DevKitM-1 #163

merged 2 commits into from
Apr 15, 2024

Conversation

veprbl
Copy link
Contributor

@veprbl veprbl commented Mar 4, 2024

image image

@pedrominatel pedrominatel added new symbol New symbol request new footprint New footprint request labels Mar 4, 2024
@pedrominatel pedrominatel self-requested a review March 5, 2024 11:44
(number "31" (effects (font (size 1.27 1.27))))
)
(pin bidirectional line (at 33.02 27.94 180) (length 2.54)
(name "U0RXD/GPIO3" (effects (font (size 1.27 1.27))))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an inconsistency in our docs.
Please change the pins:

  • Pin 32 is U0TX/GPIO1
  • Pin 33 is U0RX/GPIO3

The official Espressif documentation will be updated/fixed.

@veprbl
Copy link
Contributor Author

veprbl commented Apr 14, 2024

image image

Copy link
Member

@pedrominatel pedrominatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrominatel pedrominatel merged commit 2a2975d into espressif:main Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new footprint New footprint request new symbol New symbol request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants