-
Notifications
You must be signed in to change notification settings - Fork 34
refactor: replace WokwiCLI with Wokwi class (RDT-1428) #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
But the rest code seems to be working |
this looks like a huge improvement! could close #233 as well |
I have looked at the tests, and they have not worked successfully for a long time. Can I do something to fix them, or do they need bigger changes? |
@JakubAndrysek you don't need to worry about the test cases. the wokwi test cases are not running anyway. seems like the runner is failing... I'll take care of those. |
Hi, the PR is ready. Please review it, thanks! |
Please remove the marker here: since the CLI is not required. I removed the marker and set I’m fine with the API breaking change, as wokwi is mainly used in development, but please ensure compatibility with the existing test scripts. |
651a579
to
25e1c8b
Compare
25e1c8b
to
938717c
Compare
I have found the unimplemented feature in the client, so I have added support for uploading firmware for esp-idf through the |
Tests do not work for me also on master, I have fixed it using
Fixed in commit |
probably this PR has to be released with pytest-embedded 2.x then... we're planning to release a 2.x version that supports python >=3.10 |
Hi @JakubAndrysek now the main branch is unlocked. could you help resolve the conflicts and I'll merge this PR today? |
Hi, I have fixed Toml deps and added the updated branch to the main. Tests are running perfectly on my side. |
Thank you so much. I'll merge it today and make a dev release |
Will it be possible to add a new CI action which will run all pytest in GitHub Action, also in the forked repo? Currently, there is a custom runner in the Esprrssif infrastructure. Some tests, like serial, will be disabled in the GitHub runner, but for example, the Wokwi might be tested. |
I'll enable the wokwi tests in ci. |
oh... forgot to ask you to squash the commit history... no worries, let's improve it next time. |
This pull request migrates the Wokwi integration in
pytest-embedded-wokwi
from a CLI-based approach (wokwi-cli
) to a new synchronous Python client (wokwi-python-client
). It removes all dependencies and code related to the CLI, introduces a newWokwi
class for simulation control, and updates documentation and dependencies accordingly. The changes also update all relevant imports and interfaces in the codebase to use the newWokwi
class, and improve the documentation with usage examples for the new API.