Add CI job to check SVDs against SVD XML scheme #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, sorry for the delay in getting to this. The SVDs are generated from internal data using an internal tool, unfortunately. This could probably change, however I do not presently have the time or energy to pursue something like this. I'm not sure what to suggest regarding community contributions; I of course would love to see this, as I think it would help improve the quality of our SVDs, however I am unsure how to best facilitate these contributions. Perhaps @igrr will have some suggestions here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #27
A next PR could also add validation using SVDConv (see https://arm-software.github.io/CMSIS_5/SVD/html/svd_validate_file_pg.html), this PR is to test the waters as for whether there is any interest in having standards-compliant SVD files.
Currently, as described in #27, the tests fail. I'd like to fix that, but would like to do it in a robust way (so that when the SVDs are updated again, they don't break again). To do that, I'd need to know how the SVD files in this repo are created: are they created manually, are they generated from esp-idf, or from some Espressif-internal data? @jessebraham do you know this?