Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(uvc): Applied proprietary changes in UVC Device class #36

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

roma-jam
Copy link
Collaborator

@roma-jam roma-jam commented Nov 8, 2024

Requirements

  • Fixed uninitialized values during streaming negotiation parameters
  • Added VIDEO_CS_ITF_VS_FORMAT_FRAME_BASED support

Limitations

N/A

Breaking change

No breaking changes

Testing:

  • After applying changes the esp-video-components/esp_video/examples/uvc could be built successfully:

image

image

*NOTE: Modified component usb_device_uvc was used to enable possibility to use espressif/tinyusb component by local path.

Checklist

  • Pull Request name has appropriate format (for example: "fix(dcd_dwc2): Resolved address selection when several phy are present")
  • Optional: README.md updated
  • CI passing

Related issues

@roma-jam roma-jam self-assigned this Nov 8, 2024
@roma-jam roma-jam force-pushed the feature/proprietary_changes_uvc_class branch from 6015a99 to 0545ed7 Compare November 8, 2024 09:49
@roma-jam roma-jam force-pushed the release/v0.17 branch 3 times, most recently from 650a55f to 8502c71 Compare November 25, 2024 11:42
@roma-jam roma-jam force-pushed the feature/proprietary_changes_uvc_class branch from 0545ed7 to 4bc298f Compare November 28, 2024 18:11
@roma-jam roma-jam marked this pull request as ready for review December 3, 2024 09:58
@roma-jam roma-jam added this to the v0.17.1 milestone Dec 4, 2024
@tore-espressif
Copy link
Collaborator

Can be closed in stead of hathach#2656 ?

@roma-jam roma-jam force-pushed the feature/proprietary_changes_uvc_class branch from 4bc298f to 6243534 Compare December 9, 2024 21:30
@roma-jam roma-jam changed the title feature(uvc): Applied proprietary changed in UVC Device class feature(uvc): Applied proprietary changes in UVC Device class Dec 9, 2024
@tore-espressif
Copy link
Collaborator

@roma-jam Can we merge hathach/master to our espressif/release/v0.17 first? And then proceed with this PR?

If possible, we want to stay as close to upstream as possible, so it is not complicated to upgrade (like when we upgraded from 0.15 to 0.17)

@roma-jam
Copy link
Collaborator Author

Sure, we can.
I have created upstream synchronization PR for release/v0.17: #43

We can merge it and then return back to the current PR (but in the end only the variables initialization will left in here).

@roma-jam roma-jam force-pushed the feature/proprietary_changes_uvc_class branch from 6243534 to a36b9ac Compare December 11, 2024 18:24
@roma-jam
Copy link
Collaborator Author

The upstream synchronization #43 dropped one commit: support format frame based.
Only fix uninitialized value is left.

@roma-jam roma-jam merged commit f416167 into release/v0.17 Dec 12, 2024
88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants