Hoist linker (ld) errors to VS Code 'Problems' window (#1317)

espressif · Oct 8, 2024 · bdadcd0 · bdadcd0
1 parent bf9df82
commit bdadcd0
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -133,6 +133,21 @@
  "severity": 4,
  "message": 5
  }
+ },
+ {
+ "name": "espIdfLd",
+ "owner": "cpp",
+ "fileLocation": [
+ "autoDetect",
+ "${workspaceFolder}"
+ ],
+ "severity": "error",
+ "pattern": {
+ "regexp": "^.+\\/bin\\/ld[^:]+:\\s*(.+):(\\d+):(.+)$",
+ "file": 1,
+ "line": 2,
+ "message": 3
+ }
  }
  ],
  "viewsContainers": {

diff --git a/src/build/buildTask.ts b/src/build/buildTask.ts
@@ -210,7 +210,7 @@ export class BuildTask {
  currentWorkspaceFolder || vscode.TaskScope.Workspace,
  "ESP-IDF Compile",
  compileExecution,
- ["espIdf"],
+ ["espIdf", "espIdfLd"],
  compilePresentationOptions
  );
  compilerArgs = [];
@@ -237,7 +237,7 @@ export class BuildTask {
  currentWorkspaceFolder || vscode.TaskScope.Workspace,
  "ESP-IDF Build",
  buildExecution,
- ["espIdf"],
+ ["espIdf", "espIdfLd"],
  buildPresentationOptions
  );
  }

diff --git a/src/customTasks/customTaskProvider.ts b/src/customTasks/customTaskProvider.ts
@@ -130,7 +130,7 @@ export class CustomTask {
  currentWorkspaceFolder || TaskScope.Workspace,
  `ESP-IDF ${taskName}`,
  customExecution,
- ["espIdf"],
+ ["espIdf", "espIdfLd"],
  customTaskPresentationOptions
  );
  }