Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change compiler path to user relative path #1012

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Change compiler path to user relative path #1012

merged 3 commits into from
Jul 25, 2023

Conversation

radurentea
Copy link
Collaborator

@radurentea radurentea commented Jul 19, 2023 •
edited by kolipakakondal
Loading

Description

Changes compilerPath property in c_cpp_properties.json file from .vscode folder to use relative path.

Fixes #1010
Fixes VSC-1156

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output:

  1. Make new project using esp-idf examples.
  2. When folder is created for project, verify in .vscode folder the c_cpp_properties.json has the compilerPath contains ${config:idf.toolsPath} in it's path and it's not just an absolute path.
  • Expected behaviour:
    All functionalities should work the same

How has this been tested?

Like the ones described above.

Test Configuration:

  • ESP-IDF Version: 5.1
  • OS (Windows,Linux and macOS): macOS

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@radurentea radurentea self-assigned this Jul 19, 2023
@github-actions
Copy link

Download the artifacts for this pull request:

@kolipakakondal kolipakakondal added this to the v1.7.0 milestone Jul 25, 2023
@kolipakakondal kolipakakondal added the bug Its an actual bug as determined by the maintainers label Jul 25, 2023
brianignacio5
brianignacio5 approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radurentea radurentea merged commit 5e80b82 into master Jul 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianignacio5 brianignacio5 brianignacio5 approved these changes

Assignees

@radurentea radurentea

Labels
bug Its an actual bug as determined by the maintainers
Projects
None yet
Milestone
v1.7.0
3 participants
@radurentea @brianignacio5 @kolipakakondal