Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add setup cmd install and reuse #1028

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

brianignacio5
Copy link
Collaborator

@brianignacio5 brianignacio5 commented Aug 21, 2023

Description

Add command to use IDF setup from IDF_TOOLS_PATH/esp_idf.json and command to install ESP-IDF in default location without setting paths.

ESP-IDF: Use ESP-IDF setup from IDF Installer can be used to load IDF Setup installed with IDF Installer's esp-idf.json in IDF_TOOLS_PATH.

ESP-IDF: Install ESP-IDF can be used to install ESP-IDF and tools without UI, just write the progress in the Output Channel and save settings in the global user settings.json.

Type of change

  • New feature (non-breaking change which adds functionality)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Click on ESP-IDF: Use ESP-IDF setup from IDF Installer and select the $HOME/.espressif or %USERPROFILE%\.espressif
  2. Choose one of the existing IDF setup
  3. Observe results. Settings should be saved and the extension should be able to build and do other commands.
  4. Click ESP-IDF: Install ESP-IDF command, choose ESP-IDF path and IDF Tools path.
  5. See the progress in the ESP-IDF output channel.
  6. Observe results. Settings should be saved and the extension should be able to build and do other commands.
  • Expected behaviour:

  • Expected output:

How has this been tested?

Manual testing

Test Configuration:

  • ESP-IDF Version: 5.0
  • OS (Windows,Linux and macOS): macOS

Dependent components impacted by this PR:

  • Component 1
  • Component 2

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 self-assigned this Aug 21, 2023
@github-actions
Copy link

github-actions bot commented Aug 21, 2023

Download the artifacts for this pull request:

@brianignacio5 brianignacio5 marked this pull request as ready for review August 22, 2023 10:23
Copy link
Collaborator

@radurentea radurentea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Pull request has been marked as stale since there are no activities, and this will be closed in 5 days if there are no further activities

@github-actions github-actions bot added the stale Stale PR or Issue label Sep 8, 2023
@github-actions github-actions bot closed this Sep 13, 2023
@brianignacio5 brianignacio5 reopened this Sep 13, 2023
@brianignacio5 brianignacio5 added ongoing Ongoing Issue or PR, this label will be used for issue or PR which is to be excluded by stale bot and removed stale Stale PR or Issue labels Sep 14, 2023
@brianignacio5 brianignacio5 mentioned this pull request Apr 8, 2024
5 tasks
@AndriiFilippov
Copy link
Collaborator

@brianignacio5 hi !

Tested under:
OS - WIndows 10

I have installed ESP-IDF v5.2 using "Configure ESP-IDF extension" and then I used
"ESP-IDF: Use ESP-IDF setup from IDF Installer" and selected v5.1.2 from the dropdown list.
Then I have built the project and noticed that it still uses version 5.2.

@brianignacio5
Copy link
Collaborator Author

brianignacio5 commented Apr 10, 2024

@brianignacio5 hi !

Tested under: OS - WIndows 10

I have installed ESP-IDF v5.2 using "Configure ESP-IDF extension" and then I used "ESP-IDF: Use ESP-IDF setup from IDF Installer" and selected v5.1.2 from the dropdown list. Then I have built the project and noticed that it still uses version 5.2.

Probably because these command saves new settings in Global Scope (User Settings) but you are using Configure ESP-IDF extension to save settings in workspace folder.

EDIT: Fixed to save it to current workspace folder.

@AndriiFilippov
Copy link
Collaborator

@brianignacio5 hi !

OS - Windows 10

I did some mess in esp_idf.json file and trying to install v5.2 using "ESP-IDF: ESP-IDF setup from IDE Installer"
image

and get this error while switching from 4.4.7 to 5.2
image

I am not sure if the error message is clear enough.
Moreover, this info message telling me that command has failed, but as I can see it has switched from 4.4.7 to 5.2 somehow and build project

@AndriiFilippov AndriiFilippov modified the milestone: v1.8.0 May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ongoing Ongoing Issue or PR, this label will be used for issue or PR which is to be excluded by stale bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants