Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display of monitor the device when flash fails #1286

Merged
merged 2 commits into from
Sep 10, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/extension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3920,10 +3920,11 @@ const flash = (
workspaceRoot
) as ESP.FlashType;
}
await startFlashing(cancelToken, flashType, encryptPartition);
OutputChannel.appendLine(
"Flash has finished. You can monitor with ESP-IDF: Monitor your device command"
);
if (await startFlashing(cancelToken, flashType, encryptPartition)) {
OutputChannel.appendLine(
"Flash has finished. You can monitor your device with ESP-IDF: Monitor command"
radurentea marked this conversation as resolved.
Show resolved Hide resolved
);
}
}
);
});
Expand Down
Loading