Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: publish docs to production server #1291

Merged
merged 2 commits into from
Aug 28, 2024
Merged

fix: publish docs to production server #1291

merged 2 commits into from
Aug 28, 2024

Conversation

kolipakakondal
Copy link
Collaborator

@kolipakakondal kolipakakondal commented Aug 28, 2024

Description

Publish vscode extension docs to docs.espressif production server.
Required production keys are added.

Type of change

  • This change requires a documentation update

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Click on "Command"
  2. Execute action.
  3. Observe results.
  • Expected behaviour:

  • Expected output:

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • ESP-IDF Version:
  • OS (Windows,Linux and macOS):

Dependent components impacted by this PR:

  • Component 1
  • Component 2

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Copy link

Download the artifacts for this pull request:

Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One quick thing, we don't have release branches in general. Usually vscode keeps all releases in their Extension management for people to use older versions and each release is just a GitHub tag.

@kolipakakondal
Copy link
Collaborator Author

LGTM

One quick thing, we don't have release branches in general. Usually vscode keeps all releases in their Extension management for people to use older versions and each release is just a GitHub tag.

Ok, fixed

@kolipakakondal kolipakakondal merged commit 03f72c9 into master Aug 28, 2024
6 checks passed
@kolipakakondal kolipakakondal deleted the docs_publish branch August 28, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants