Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Provide CN translation for multiple-projects.rst #1391

Merged
merged 1 commit into from
Jan 8, 2025
Merged

docs: Provide CN translation for multiple-projects.rst #1391

merged 1 commit into from
Jan 8, 2025

Conversation

Shen765
Copy link
Collaborator

@Shen765 Shen765 commented Jan 2, 2025

Description

This PR:

  • Adjusts some format issues and unclear expressions in multiple-projects.rst based on Espressif Style Guide
  • Provides CN translation for docs_espressif/en/additionalfeatures/multiple-projects.rst
  • TODO: Closes DOC-9941 once merged

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025 •
edited
Loading

Download the artifacts for this pull request:
You can test these changes by installing this VSIX by click menu View -> Command Palette..., type Install from VSIX and then select downloaded esp-idf-extension.vsix file to install the extension.

@Shen765 Shen765 self-assigned this Jan 2, 2025
@Shen765 Shen765 added the documentation 📝 Solely about the documentation of the project. label Jan 2, 2025
@Shen765
Copy link
Collaborator Author

Shen765 commented Jan 2, 2025

Hi @zztiger123 Pls help review the CN translation for multiple-projects.rst. Thx!

Daiziyan0225
Daiziyan0225 reviewed Jan 6, 2025
View reviewed changes
Copy link

@Daiziyan0225 Daiziyan0225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Shen765, I left some minor comments. Please check.

docs_espressif/zh_CN/additionalfeatures/multiple-projects.rst Outdated Show resolved Hide resolved
docs_espressif/zh_CN/additionalfeatures/multiple-projects.rst Outdated Show resolved Hide resolved
docs_espressif/zh_CN/additionalfeatures/multiple-projects.rst Outdated Show resolved Hide resolved
@Shen765 Shen765 force-pushed the docs/translate_multiple_projects branch from 8edb900 to 54bb652 Compare January 7, 2025 03:52
@Shen765
Copy link
Collaborator Author

Shen765 commented Jan 7, 2025

Hi @Daiziyan0225 Already edited this document. Pls help approve, thx :)

Daiziyan0225
Daiziyan0225 approved these changes Jan 7, 2025
View reviewed changes
Copy link

@Daiziyan0225 Daiziyan0225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Shen765, LGTM.

@Shen765 Shen765 force-pushed the docs/translate_multiple_projects branch from 54bb652 to 0b64630 Compare January 7, 2025 06:55
@Shen765 Shen765 force-pushed the docs/translate_multiple_projects branch from 0b64630 to 687243e Compare January 8, 2025 06:56
@Shen765 Shen765 merged commit 1867b25 into master Jan 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daiziyan0225 Daiziyan0225 Daiziyan0225 approved these changes

@zztiger123 zztiger123 zztiger123 approved these changes

Assignees

@Shen765 Shen765

Labels
documentation 📝 Solely about the documentation of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shen765 @zztiger123 @Daiziyan0225