Libpdfium build 2 files found (pickFirst) #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It works for me |
|
@espresso3389 are you fine to approve this PR or you would prefer to look for another solution ? |
|
As I descibed on #8 (comment), this change is just a workaround and sometimes it gets very harmful. We need more discussion on it on #8 before accepting such PRs. |
|
After several hours of investigation, I finally decided to merge this anyway. There might be several side effects but the possibilities are so small. The risk can be acceptable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temp fix for the building bug of 2 files found for libpdfium.so