Updated ROCm to latest #166
Conversation
| @@ -1,6 +1,6 @@ | |||
| FROM rocm/dev-ubuntu-18.04:3.0 | |||
| FROM rocm/dev-ubuntu-18.04:latest | |||
There was a problem hiding this comment.
I'd prefer to pin this to 3.3 so that it's clear which base image is used in that dockerfile.
There was a problem hiding this comment.
Then we need to put some procedure in place to regularly test against latest so we see when new versions break things. We should probably do the same for CUDA, where we tend to be at least 6 months behind on testing and support. CUDA typically also requires minor fixes to support a new release, and unless they are using Ubuntu's packages, people tend to upgrade their CUDA relatively quickly.
|
There is no testing and no building for PRs at the moment. It's being worked on in #163; once merged into this PR, the pipeline here will build the image and fail if the dockerfile is incorrect. You can then use the commit SHA in an espressomd/espresso PR to test the image there. |
Since espressomd/espresso#3623, this should work now. I commented out the
sedline because we might need it again in the future.I have no idea how testing works now that @KaiSzuttor's changes are merged, so please do whatever is necessary.