Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from DockerHub registry to GitHub registry #212

Merged
merged 4 commits into from
Apr 6, 2023
Merged

Migrate from DockerHub registry to GitHub registry #212

merged 4 commits into from
Apr 6, 2023

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Apr 5, 2023

Description of changes:

  • no longer push images to the DockerHub espressomd organization
  • generate a more compact Debian image without Stokesian Dynamics dependencies to reduce pull times
  • generate images suitable for GitHub Actions (without a USER layer) with a special tag
    • generating alternative versions that work out-of-the-box for Docker users (helps with debugging)

jngrad added 4 commits March 31, 2023 12:44
@jngrad
Remove DockerHub deploy stage
8d78c3a
@jngrad
Remove DEBIAN_FRONTEND environment variable
b5b7dd4 
Is it not good practice to set the DEBIAN_FRONTEND environment
variable in a Docker image since it will persist in derived images.
Instead, set this variable only on the relevant command lines.
@jngrad
Upgrade Debian dependencies
dcdbb77
@jngrad
Generate images suitable for GitHub Actions
f55dcbf 
GitHub Actions require images without any custom USER or WORKDIR:
https://docs.github.com/en/actions/creating-actions/dockerfile-support-for-github-actions
@jngrad
Copy link
Member Author

jngrad commented Apr 5, 2023

@reinaual The GitHub Actions for debian and ubuntu-wo-dependencies were tested using the container registry of my fork. You can see the results here: run 4611094698.

@jngrad jngrad requested a review from reinaual April 5, 2023 20:32
@jngrad jngrad merged commit f6cf740 into espressomd:main Apr 6, 2023
@jngrad jngrad deleted the github-actions branch April 6, 2023 17:26
@jngrad jngrad mentioned this pull request Apr 12, 2023
Merged
kodiakhq bot added a commit to espressomd/espresso that referenced this pull request Apr 17, 2023
@kodiakhq
Redesign GitHub Actions workflows (#4706)
97d06af 
Follow-up to espressomd/docker#212

Description of changes:
- move `debian` and `ubuntu-wo-dependencies` jobs to GitHub Actions
- remove brittle macOS `sanitizer_check` job from the scheduled jobs
- introduce ccache on all GitHub Actions to reduce compilation times
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reinaual reinaual reinaual approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jngrad @reinaual