Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark checkpointing as experimental and add more tests #2896

Closed
RudolfWeeber opened this issue Jun 11, 2019 · 5 comments
Closed

Mark checkpointing as experimental and add more tests #2896

RudolfWeeber opened this issue Jun 11, 2019 · 5 comments
Labels

Comments

@RudolfWeeber
Copy link
Contributor

No description provided.

@KaiSzuttor KaiSzuttor added this to the Espresso 4.1 milestone Jul 15, 2019
@RudolfWeeber
Copy link
Contributor Author

The docs now clearly state the limitations and limited testability.
I'm de-milestoning this, but we should add an end-to-end test with a reasonably complex simulation setup in the long run.

@RudolfWeeber RudolfWeeber modified the milestones: Espresso 4.1, Espresso 5 Aug 6, 2019
@KaiSzuttor
Copy link
Member

@RudolfWeeber have you checked the coverage of the checkpointing tests?

@RudolfWeeber
Copy link
Contributor Author

RudolfWeeber commented Aug 6, 2019 via email

@jngrad
Copy link
Member

jngrad commented Oct 19, 2019

Tests were added for constraints (#3105), thermostats and integrators (#3245) checkpointing in 4.1.1.

@jngrad jngrad removed the CodingDay label Feb 6, 2020
@jngrad jngrad changed the title Mark checkpoitning as experimental and add more tests Mark checkpointing as experimental and add more tests Aug 4, 2021
@jngrad jngrad added the Testcase label Aug 4, 2021
@jngrad
Copy link
Member

jngrad commented Aug 4, 2021

Progress report:

  • checkpointing testing has improved considerably since 4.1.1
  • multiple combinations of features are tested to detect interactions (e.g. due to the order in which global variables are reloaded)
  • accidental double checkpointing of global variables has been sorted out (Remove globals.pyx #4276)
  • non-checkpointable features raise an exception when checkpointed (Catch ObjectList checkpointing bug #4287)

@jngrad jngrad removed this from the Espresso 5 milestone Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants