Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove globals.pyx #4276

Merged
merged 15 commits into from
Jun 8, 2021
Merged

Remove globals.pyx #4276

merged 15 commits into from
Jun 8, 2021

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Jun 7, 2021 •
edited
Loading

Partial fix for #2628

Description of changes:

  • pass time_step and sim_time as function arguments
  • make skin_set and verlet_reuse static
  • move logic from globals.pyx to the relevant .pyx files
  • API changes:
    • member system.globals no longer exists
    • several electrostatic/magnetostatic methods now have a timings optional argument to control the number of force calculations during tuning

@jngrad jngrad requested a review from reinaual June 7, 2021 13:13
@jngrad jngrad added this to the Espresso 4.2 milestone Jun 7, 2021
reinaual
reinaual previously approved these changes Jun 8, 2021
View reviewed changes
@jngrad jngrad added the automerge Merge with kodiak label Jun 8, 2021
@kodiakhq kodiakhq bot merged commit 7eaf45f into espressomd:python Jun 8, 2021
@jngrad jngrad deleted the remove_globals_pyx branch June 8, 2021 16:27
@jngrad jngrad mentioned this pull request Aug 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaiSzuttor KaiSzuttor KaiSzuttor approved these changes

@reinaual reinaual reinaual left review comments

Assignees
No one assigned
Labels
ApiChange automerge Merge with kodiak CodeQuality Core Python
Projects
None yet
Milestone
Espresso 4.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jngrad @KaiSzuttor @reinaual