Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use published result to check LJ rdf in tutorials test #3185

Closed
jonaslandsgesell opened this issue Sep 20, 2019 · 1 comment · Fixed by #3408
Closed

Use published result to check LJ rdf in tutorials test #3185

jonaslandsgesell opened this issue Sep 20, 2019 · 1 comment · Fixed by #3408

Comments

@jonaslandsgesell
Copy link
Member

We could show the published result for the LJ rdf in the tutorial and use it in the test for the LJ tutorial:

https://www.sciencedirect.com/science/article/pii/S0301010404005452
@jonaslandsgesell
Copy link
Member Author

Mentioned in #3058

@jngrad jngrad mentioned this issue Jan 8, 2020
Merged
kodiakhq bot added a commit that referenced this issue Jan 22, 2020
@kodiakhq
Update tutorials and improve tutorial testing framework (#3408)
5705c67 
Description of changes:
- tutorial 05 raspberry electrophoresis (fixes #3058)
   - plot the final trajectory in a matplotlib 3D plot
   - add test to check the raspberry traveled a longer distance over the axis of the E-field
   - test the sample .dat file as well
- tutorial 01 Lennard-Jones (fixes #3185)
   - plot and test the experimental RDF against the theoretical RDF
- tutorial 04 LB Part 4 solution script
   - added the solution script in the HTML output and fixed its test
- use AST to process Jupyter notebooks containing matplotlib code (fixes #3215)
- fix CMake dependency resolution for tutorials
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update tutorials and improve tutorial testing framework jngrad/espresso
1 participant
@jonaslandsgesell