Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lees Edwards: Oscillatory shear #4477

Closed
bindgens1 opened this issue Mar 18, 2022 · 0 comments · Fixed by #4489
Closed

Lees Edwards: Oscillatory shear #4477

bindgens1 opened this issue Mar 18, 2022 · 0 comments · Fixed by #4489

Comments

@bindgens1
Copy link
Member

bindgens1 commented Mar 18, 2022 •
edited
Loading

Oscillatory shear does not allow to use the parameter "initial position offset".
This might be needed if we first do linear shear and then switch to oscillatory shear.

Also the user guide calls the parameter frequency instead of omega.
@jngrad jngrad mentioned this issue Apr 4, 2022
Merged
@kodiakhq kodiakhq bot closed this as completed in #4489 Apr 6, 2022
kodiakhq bot added a commit that referenced this issue Apr 6, 2022
@kodiakhq
Python maintenance (#4489)
a91b0dc 
Fixes #4488, fixes  #4490, fixes #4491, fixes #4477

Description of changes:
- require Python 3.8+ (as per #3421)
- use `contextlib` in the testsuite to better handle `ImportError` from missing dependencies
- use `pathlib` in the testsuite and scripts for portability on non-Posix environments
- modernize python testsuite, fix broken test cases, improve code coverage
- implement initial position offset for LEbc protocol `OscillatoryShear`
- use new CI infrastructure: run jobs on 4 cores (reduce test runtime by 30%), update labels to better utilize GPU runners
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Python maintenance jngrad/espresso
1 participant
@bindgens1