Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing feature guard #4644

Closed
RudolfWeeber opened this issue Jan 2, 2023 · 1 comment · Fixed by #4648
Closed

Missing feature guard #4644

RudolfWeeber opened this issue Jan 2, 2023 · 1 comment · Fixed by #4648
Assignees

Comments

@RudolfWeeber
Copy link
Contributor

RudolfWeeber commented Jan 2, 2023

Espresso built with Cuda does not load due to an undefined symbol for the following myconfig (default minus VIRTUAL_SITES_INERTIALESS_TRACERS)

/*
 * Copyright (C) 2010-2022 The ESPResSo project
 * Copyright (C) 2002,2003,2004,2005,2006,2007,2008,2009,2010
 *   Max-Planck-Institute for Polymer Research, Theory Group
 *
 * This file is part of ESPResSo.
 *
 * ESPResSo is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * ESPResSo is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */

/*
 * This is the default myconfig.hpp file.
 * When users don't supply a myconfig.hpp file, this file is used.
 *
 * DO NOT MODIFY THIS FILE! It should be modified *only* by the
 * maintainers of ESPResSo, as it has a profound impact on many users.
 */

// Geometry, equation of motion, thermostat/barostat
#define ROTATION
#define ROTATIONAL_INERTIA
#define MASS
#define PARTICLE_ANISOTROPY
#define EXTERNAL_FORCES
#define THERMOSTAT_PER_PARTICLE
#define BOND_CONSTRAINT
#define NPT
#define DPD

// Charges and dipoles
#define ELECTROSTATICS
#ifdef CUDA
#define MMM1D_GPU
#endif
#define DIPOLES

// Active matter
#define ENGINE

// Hydrodynamics, Electrokinetics
#define LB_BOUNDARIES
#ifdef CUDA
#define LB_BOUNDARIES_GPU
#define ELECTROKINETICS
#define EK_BOUNDARIES
#endif

// Force/energy calculation
#define EXCLUSIONS

// Long-range interactions
#define TABULATED
#define LENNARD_JONES
#define LENNARD_JONES_GENERIC
#define LJGEN_SOFTCORE
#define LJCOS
#define LJCOS2
#define GAUSSIAN
#define HAT
#define SMOOTH_STEP
#define HERTZIAN
#define SOFT_SPHERE
#define WCA

#ifdef FFTW
#define THOLE
#endif

// Further features
#define VIRTUAL_SITES_RELATIVE
#define COLLISION_DETECTION
@jngrad
Copy link
Member

jngrad commented Jan 2, 2023

I don't get any undefined symbol. Apart from a missing feature guard in the ekin test, the testsuite passes from my side, using either NVCC or Clang as the CUDA compiler.

@jngrad jngrad self-assigned this Jan 9, 2023
jngrad added a commit that referenced this issue Jan 12, 2023
Fixes #4644
Fixes #4645
Pre-requisite to #4629

Description of changes:
- bugfix: the type map is now properly updated when clearing particles
- add missing feature guards in the testsuite
- add subtests to provide more context when a test fails
jngrad added a commit to jngrad/espresso that referenced this issue Jan 19, 2023
Fixes espressomd#4644
Fixes espressomd#4645

Description of changes:
- bugfix: the type map is now properly updated when clearing particles
- add missing feature guards in the testsuite
- add subtests to provide more context when a test fails
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants