Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some sphinx fixes and removed private and special members from sphinx… #1296

Merged
merged 3 commits into from
Aug 16, 2017

Conversation

KaiSzuttor
Copy link
Member

@KaiSzuttor KaiSzuttor commented Aug 8, 2017

… documentation.

Fixes #1284

@mkuron
Copy link
Member

mkuron commented Aug 8, 2017

How does this deal with ParticleSlice? Since #1160, most properties are dynamically created, only pos_folded, add_exclusion and delete_exclusion are statically declared in the base class, _ParticleSliceImpl.

@KaiSzuttor
Copy link
Member Author

@mkuron I don't quite get your point, this PR does not change anything of the documentation behavior besides removing private and special members.

@mkuron
Copy link
Member

mkuron commented Aug 8, 2017

Isn't _ParticleSliceImpl private with that underscore at the beginning?

@KaiSzuttor
Copy link
Member Author

But aren't these properties documented in the ParticleHandle class?

@mkuron
Copy link
Member

mkuron commented Aug 8, 2017

Only the ones that are automatically added, not the statically-declared ones in the base class. Just look at the sphinx documentation to see whether they show up with documentation or not.

@KaiSzuttor
Copy link
Member Author

As far as I can see they show up in the documentation. Please counter-check yourself @mkuron .

@KaiSzuttor
Copy link
Member Author

KaiSzuttor commented Aug 9, 2017

Since sphinx also includes inherited members, the ones @mkuron was mentioning are included.

import espressomd from espressomd import checkpointing import signal

checkpoint = checkpointing.Checkpointing(checkpoint\_id=“mycheckpoint”)
checkpoint = checkpointing.Checkpointing(checkpoint_id=“mycheckpoint”)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are smart quotes used here (“”) instead of straight ones (""), which makes this invalid Python code. Since you're touching the line anyway, please fix this.

@fweik
Copy link
Contributor

fweik commented Aug 10, 2017

So we're good now?

@fweik fweik merged commit 917cde2 into espressomd:python Aug 16, 2017
@KaiSzuttor KaiSzuttor deleted the singleton branch September 26, 2017 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants