Fix PARTIAL_PERIODIC on big-endian platforms #2259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fweik
approved these changes
Sep 13, 2018
RudolfWeeber
pushed a commit
to RudolfWeeber/espresso
that referenced
this pull request
Oct 15, 2018
Fix PARTIAL_PERIODIC on big-endian platforms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem reported by @junghans in #2258.
I spun up OpenSUSE Tumbleweed in a Docker container to emulate an IBM mainframe with s390x CPU in QEMU. The PARTIAL_PERIODIC tests were failing just like on the SUSE Build Service due to a byte-order issue. Also I needed to add one Boost header to make it work with Boost 1.64.0 (see boostorg/serialization@1d86261).
I expect that this also fixes the ppc64 issue, but couldn't test that because there are no Docker images for it (only for ppc64le). ppc64 might still be somewhat relevant in HPC as there are a few IBM BlueGene/Q machines still in operation. I really can't imagine why anyone would run Espresso on s390x; IBM's zEnterprise mainframe architecture that just isn't optimized for this kind of workload.
Candidate for Espresso 4.0.1.