Test observable_cylindricalLB: Split CPU and GPU Parts and Correct skipIfs #2272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## python #2272 +/- ##
======================================
Coverage 71% 71%
======================================
Files 377 377
Lines 18946 18946
======================================
Hits 13585 13585
Misses 5361 5361Continue to review full report at Codecov.
|
pkreissl
force-pushed
the
test_observable_cylindricalLB
branch
from
19905a4
to
36a9934
Compare
|
the whole test is poorly written, I think it's a quickfix but we need to improve that testcase and remove code duplication by using inheritance like in the other tests that test cpu and gpu LB. |
fweik
approved these changes
Sep 20, 2018
RudolfWeeber
pushed a commit
to RudolfWeeber/espresso
that referenced
this pull request
Oct 15, 2018
…ndricalLB Test observable_cylindricalLB: Split CPU and GPU Parts and Correct skipIfs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
observable_cylindricalLB.pyhas incorrectskipIfs. It is skipped ifLB_GPUis not compiled in (orSHANCHENis activated), however it also relies on theLBfeature.The test wrongly fails, when
LB_GPUis compiled andLBis not compiled in.Is fixed by this PR, which splits cpu and gpu parts of the test functions and skips correctly.