Py: pickle support for collision detection + test #2342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pickling is based on the CollisionDetection.get_params() method. The consistency of get_params() and get_params() is checked in the collision detection test in addition to the the restore function
fweik
approved these changes
Oct 28, 2018
KaiSzuttor
suggested changes
Oct 28, 2018
| @@ -52,6 +52,12 @@ class CollisionDetection(ut.TestCase): | |||
| part_type_after_glueing = 3 | |||
| other_type = 5 | |||
|
|
|||
|
|
|||
| def get_state_set_state_consistency(self): | |||
| state=self.s.collision_detection.get_params() | |||
There was a problem hiding this comment.
could you please add that check to the checkpoint test?
Codecov Report
@@ Coverage Diff @@
## python #2342 +/- ##
======================================
Coverage 71% 71%
======================================
Files 381 381
Lines 18905 18905
======================================
Hits 13587 13587
Misses 5318 5318Continue to review full report at Codecov.
|
RudolfWeeber
pushed a commit
to RudolfWeeber/espresso
that referenced
this pull request
Oct 28, 2018
Py: pickle support for collision detection + test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1943