Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix mentioning h5py #2353

Merged
merged 2 commits into from
Oct 30, 2018
Merged

fix mentioning h5py #2353

merged 2 commits into from
Oct 30, 2018

Conversation

jonaslandsgesell
Copy link
Member

@jonaslandsgesell jonaslandsgesell commented Oct 30, 2018 •
edited
Loading

Fixes #2286

@jonaslandsgesell jonaslandsgesell changed the title fixes #2286 fix mentioning h5py Oct 30, 2018
@codecov
Copy link

codecov bot commented Oct 30, 2018 •
edited
Loading

Codecov Report

Merging #2353 into python will increase coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           python   #2353    +/-   ##
=======================================
+ Coverage      71%     71%   +<1%     
=======================================
  Files         381     381            
  Lines       18905   18905            
=======================================
+ Hits        13567   13587    +20     
+ Misses       5338    5318    -20
Impacted Files Coverage Δ
src/core/layered.cpp 79% <0%> (ø) ⬆️
src/core/domain_decomposition.cpp 91% <0%> (+3%) ⬆️
src/core/lattice.cpp 89% <0%> (+6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22d2ad9...7b39030. Read the comment docs.

@fweik fweik merged commit ca688d8 into espressomd:python Oct 30, 2018
@fweik fweik added this to the Espresso 4.0.1 milestone Oct 30, 2018
RudolfWeeber pushed a commit to RudolfWeeber/espresso that referenced this pull request Nov 1, 2018
@fweik @RudolfWeeber
Merge pull request espressomd#2353 from jonaslandsgesell/patch-7
e641d30 
fix mentioning h5py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fweik fweik fweik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Espresso 4.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jonaslandsgesell @fweik @KaiSzuttor