Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support neutral charges in the reaction ensemble #2378

Merged
merged 2 commits into from
Nov 30, 2018

Conversation

thepith
Copy link
Contributor

@thepith thepith commented Nov 20, 2018

Fixes #2374

If all particles have zero charge, electroneutrality is always given.

Description of changes:

  • check if any charges are present, before checking for electroneutrality

@codecov
Copy link

codecov bot commented Nov 20, 2018

Codecov Report

Merging #2378 into python will increase coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           python   #2378    +/-   ##
=======================================
+ Coverage      72%     72%   +<1%     
=======================================
  Files         397     397            
  Lines       18765   18765            
=======================================
+ Hits        13571   13594    +23     
+ Misses       5194    5171    -23
Impacted Files Coverage Δ
src/core/layered.cpp 78% <0%> (ø) ⬆️
src/core/domain_decomposition.cpp 95% <0%> (+4%) ⬆️
src/core/lattice.cpp 89% <0%> (+6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6db364c...4a054f7. Read the comment docs.

@RudolfWeeber RudolfWeeber added this to the Espresso 4.0.1 milestone Nov 22, 2018
@RudolfWeeber RudolfWeeber merged commit 2b6579a into espressomd:python Nov 30, 2018
RudolfWeeber added a commit to RudolfWeeber/espresso that referenced this pull request Nov 30, 2018
Support neutral charges in the reaction ensemble
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants