Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build in container without external dependencies. #2406

Merged
merged 9 commits into from
Dec 17, 2018

Conversation

KaiSzuttor
Copy link
Member

@KaiSzuttor KaiSzuttor commented Dec 7, 2018

Fixes #2347
Depends on espressomd/docker#47
Description of changes:

  • added a job to gitlab ci
  • guarded THOLE in maxset.hpp

@codecov
Copy link

codecov bot commented Dec 7, 2018

Codecov Report

Merging #2406 into python will decrease coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           python   #2406   +/-   ##
======================================
- Coverage      72%     72%   -1%     
======================================
  Files         397     396    -1     
  Lines       18666   18629   -37     
======================================
- Hits        13496   13454   -42     
- Misses       5170    5175    +5
Impacted Files Coverage Δ
src/core/communication.cpp 77% <ø> (ø) ⬆️
src/core/forces.cpp 82% <ø> (ø) ⬆️
src/core/energy.cpp 83% <ø> (ø) ⬆️
...core/bonded_interactions/bonded_coulomb_p3m_sr.hpp 0% <0%> (-62%) ⬇️
src/core/forces_inline.hpp 72% <0%> (-2%) ⬇️
src/core/energy_inline.hpp 58% <0%> (-1%) ⬇️
...re/bonded_interactions/bonded_interaction_data.hpp 100% <0%> (ø) ⬆️
src/core/nonbonded_interactions/thole.hpp

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a485cc...bbb1b47. Read the comment docs.

@KaiSzuttor KaiSzuttor changed the title WIP build in container without external dependencies. build in container without external dependencies. Dec 11, 2018
@KaiSzuttor KaiSzuttor merged commit 4a7cafd into espressomd:python Dec 17, 2018
@KaiSzuttor KaiSzuttor deleted the features branch December 18, 2018 09:25
RudolfWeeber pushed a commit to RudolfWeeber/espresso that referenced this pull request Dec 18, 2018
build in container without external dependencies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants