core: Fixed find_current_cell #2410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## python #2410 +/- ##
=======================================
+ Coverage 72% 72% +<1%
=======================================
Files 397 397
Lines 18659 18670 +11
=======================================
+ Hits 13484 13498 +14
+ Misses 5175 5172 -3
Continue to review full report at Codecov.
|
|
Can be merged |
|
Ah I did not consider that. Looks ok.
…On Wed, Dec 12, 2018 at 6:18 PM RudolfWeeber ***@***.***> wrote:
@fweik <https://github.com/fweik>, for the 401 branch, I just
cherry-picked
a0ad77b
<a0ad77b>
because otherwise some of the resort stuff leaks in.
Can you please check the 401test branch on my repo?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2410 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA2i344AzDJtV8sDNR30hu0hC60ZiDhUks5u4TqBgaJpZM4ZJBow>
.
--
Florian Weik
florianweik@gmail.com
++49 157 85939252
|
This was referenced Jan 15, 2019
RudolfWeeber
added a commit
to RudolfWeeber/espresso
that referenced
this pull request
Jan 15, 2019
RudolfWeeber
added a commit
that referenced
this pull request
Jan 16, 2019
Core: Backport particle deletion code from pr #2410
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old implementation could potentially return a ghost cell or no cell as cell for a local particle,
but neighbor search on ghost cells is no possible. (They do not have neighbors set).
It's correct to always use
pos_oldto find the cell: this is the position the particlewas last sorted with, and hence will find the cell the particle is actually in. From my understanding
of the collision detection this meant that in some corner cases pairs were missed, but
I am not sure about that.