Core: fold_coordinate rewrite to avoid rounding corner cases #2415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## python #2415 +/- ##
=======================================
+ Coverage 72% 72% +<1%
=======================================
Files 397 397
Lines 18670 18666 -4
=======================================
+ Hits 13495 13496 +1
+ Misses 5175 5170 -5
Continue to review full report at Codecov.
|
mkuron
approved these changes
Dec 13, 2018
fweik
approved these changes
Dec 13, 2018
RudolfWeeber
pushed a commit
to RudolfWeeber/espresso
that referenced
this pull request
Dec 18, 2018
Core: fold_coordinate rewrite to avoid rounding corner cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-epsilon is folded to +box_l which is not a folded coordinate.
@fweik
@mkuron, this fixes the collision detection test on i386.