CMake: Default with_scafacos = off, since it requries ELECTROSTATICS #2417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## python #2417 +/- ##
=======================================
+ Coverage 72% 72% +<1%
=======================================
Files 393 393
Lines 18483 18483
=======================================
+ Hits 13411 13432 +21
+ Misses 5072 5051 -21
Continue to review full report at Codecov.
|
fweik
approved these changes
Dec 14, 2018
fweik
suggested changes
Jan 7, 2019
| @@ -84,7 +84,7 @@ if [[ ! -z ${with_coverage+x} ]]; then | |||
| bash <(curl -s https://codecov.io/env) &> /dev/null; | |||
| fi | |||
|
|
|||
| cmake_params="-DCMAKE_BUILD_TYPE=$build_type -DPYTHON_EXECUTABLE=$(which python$python_version) -DWARNINGS_ARE_ERRORS=ON -DTEST_NP:INT=$check_procs $cmake_params" | |||
| cmake_params="-DCMAKE_BUILD_TYPE=$build_type -DPYTHON_EXECUTABLE=$(which python$python_version) -DWARNINGS_ARE_ERRORS=ON -DTEST_NP:INT=$check_procs $cmake_params -DWITH_SCAFACOS=ON" | |||
There was a problem hiding this comment.
I don't think you can do -DWITH_SCAFACOS=ON in the build script for all builds as there are containers where there is now scafacos; on these the build should fail now.
|
On Sun, Jan 06, 2019 at 11:51:26PM -0800, Florian Weik wrote:
fweik requested changes on this pull request.
> @@ -84,7 +84,7 @@ if [[ ! -z ${with_coverage+x} ]]; then
bash <(curl -s https://codecov.io/env) &> /dev/null;
fi
-cmake_params="-DCMAKE_BUILD_TYPE=$build_type -DPYTHON_EXECUTABLE=$(which python$python_version) -DWARNINGS_ARE_ERRORS=ON -DTEST_NP:INT=$check_procs $cmake_params"
+cmake_params="-DCMAKE_BUILD_TYPE=$build_type -DPYTHON_EXECUTABLE=$(which python$python_version) -DWARNINGS_ARE_ERRORS=ON -DTEST_NP:INT=$check_procs $cmake_params -DWITH_SCAFACOS=ON"
I don't think you can do `-DWITH_SCAFACOS=ON` in the build script for all builds as there are containers where there is now scafacos; on these the build should fail now.
Just like WITH_CUDA, the switch enables the detection, not the
actual use.
|
fweik
approved these changes
Jan 7, 2019
|
Fine with me, the main point was to avoid the build failures. |
RudolfWeeber
added a commit
to RudolfWeeber/espresso
that referenced
this pull request
Jan 7, 2019
CMake: Default with_scafacos = off, since it requries ELECTROSTATICS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2414.
@fweik