Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use directed acyclic graphs in gitlab CI #3109

Merged
merged 1 commit into from
Aug 30, 2019

Conversation

RudolfWeeber
Copy link
Contributor

No description provided.

@RudolfWeeber RudolfWeeber force-pushed the gitlab_dag branch 2 times, most recently from 3f108b0 to 8d59825 Compare August 29, 2019 16:27
@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #3109 into python will increase coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           python   #3109     +/-   ##
========================================
+ Coverage      83%     83%    +<1%     
========================================
  Files         530     513     -17     
  Lines       26141   24604   -1537     
========================================
- Hits        21954   20664   -1290     
+ Misses       4187    3940    -247
Impacted Files Coverage Δ
...al_sites/lb_inertialess_tracers_cuda_interface.cpp 0% <0%> (-100%) ⬇️
...rialization/ibm_cuda_particle_velocities_input.hpp 0% <0%> (-100%) ⬇️
src/core/actor/ActorList.cpp 0% <0%> (-80%) ⬇️
src/core/EspressoSystemInterface.cpp 40% <0%> (-52%) ⬇️
...tatics_magnetostatics/magnetic_non_p3m_methods.cpp 0% <0%> (-37%) ⬇️
...rc/core/grid_based_algorithms/lb_interpolation.cpp 78% <0%> (-12%) ⬇️
src/script_interface/shapes/Slitpore.hpp 80% <0%> (-11%) ⬇️
src/script_interface/shapes/HollowCone.hpp 75% <0%> (-9%) ⬇️
src/core/electrostatics_magnetostatics/dipole.cpp 58% <0%> (-6%) ⬇️
src/core/forces.cpp 96% <0%> (-4%) ⬇️
... and 168 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2e7c5d...553b01b. Read the comment docs.

@jngrad
Copy link
Member

jngrad commented Aug 29, 2019

For reference: DAG in GitLab-CI, short explanation, documentation

@RudolfWeeber RudolfWeeber changed the title WIP: Use directed acyclic graphs in gitlab CI Use directed acyclic graphs in gitlab CI Aug 30, 2019
@RudolfWeeber
Copy link
Contributor Author

As far as I can tell from yesterday's build, itś working.

@jngrad
Copy link
Member

jngrad commented Aug 30, 2019

This could also help in our docker repository, where stage N only starts after the slowest job at stage N-1 is complete. This would give us faster feedback during a PR and faster deployment after a merge. The only drawback I can think of is the possibility of a race condition during CI of a merge: a job at stage 1 might not start until a job at stage 3 is complete that requires a runner with the same tags, causing some images to be deployed later than expected. This concern is however irrelevant to the espresso repository.

@jngrad
Copy link
Member

jngrad commented Aug 30, 2019

bors r+

bors bot added a commit that referenced this pull request Aug 30, 2019
3105: Fix Constraint checkpointing r=RudolfWeeber a=jngrad

Fixes #2943

Enable checkpointing of all `Constraint` classes which are not based on shapes. This also solves the iterator issue in #2943.

API change: it is now required to instantiate all `Constraint` classes with named arguments instead of positional arguments.


3109: Use directed acyclic graphs in gitlab CI r=jngrad a=RudolfWeeber



Co-authored-by: Jean-Noël Grad <jgrad@icp.uni-stuttgart.de>
Co-authored-by: Rudolf Weeber <weeber@icp.uni-stuttgart.de>
@bors
Copy link
Contributor

bors bot commented Aug 30, 2019

Build succeeded

@bors bors bot merged commit 553b01b into espressomd:python Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants