-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use directed acyclic graphs in gitlab CI #3109
Conversation
3f108b0
to
8d59825
Compare
Codecov Report
@@ Coverage Diff @@
## python #3109 +/- ##
========================================
+ Coverage 83% 83% +<1%
========================================
Files 530 513 -17
Lines 26141 24604 -1537
========================================
- Hits 21954 20664 -1290
+ Misses 4187 3940 -247
Continue to review full report at Codecov.
|
For reference: DAG in GitLab-CI, short explanation, documentation |
8d59825
to
553b01b
Compare
As far as I can tell from yesterday's build, itś working. |
This could also help in our docker repository, where stage N only starts after the slowest job at stage N-1 is complete. This would give us faster feedback during a PR and faster deployment after a merge. The only drawback I can think of is the possibility of a race condition during CI of a merge: a job at stage 1 might not start until a job at stage 3 is complete that requires a runner with the same tags, causing some images to be deployed later than expected. This concern is however irrelevant to the espresso repository. |
bors r+ |
3105: Fix Constraint checkpointing r=RudolfWeeber a=jngrad Fixes #2943 Enable checkpointing of all `Constraint` classes which are not based on shapes. This also solves the iterator issue in #2943. API change: it is now required to instantiate all `Constraint` classes with named arguments instead of positional arguments. 3109: Use directed acyclic graphs in gitlab CI r=jngrad a=RudolfWeeber Co-authored-by: Jean-Noël Grad <jgrad@icp.uni-stuttgart.de> Co-authored-by: Rudolf Weeber <weeber@icp.uni-stuttgart.de>
Build succeeded |
No description provided.