Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ELC Coverage, integer flags converted #3123

Merged
merged 12 commits into from
Sep 6, 2019
Merged

ELC Coverage, integer flags converted #3123

merged 12 commits into from
Sep 6, 2019

Conversation

reinaual
Copy link
Contributor

@reinaual reinaual commented Sep 5, 2019

Should fix #2685 for the neutral case.
Also converted integer flags to boolean in ELC and MMM2D.

@codecov
Copy link

codecov bot commented Sep 5, 2019 •
edited
Loading

Codecov Report

Merging #3123 into python will increase coverage by <1%.
The diff coverage is 89%.

Impacted file tree graph

@@           Coverage Diff           @@
##           python   #3123    +/-   ##
=======================================
+ Coverage      83%     84%   +<1%     
=======================================
  Files         530     530            
  Lines       26141   26142     +1     
=======================================
+ Hits        21949   22157   +208     
+ Misses       4192    3985   -207
Impacted Files Coverage Δ
src/core/electrostatics_magnetostatics/mmm2d.hpp 100% <ø> (ø) ⬆️
src/core/electrostatics_magnetostatics/mmm2d.cpp 90% <87%> (ø) ⬆️
src/core/electrostatics_magnetostatics/elc.cpp 98% <90%> (+24%) ⬆️
src/core/particle_data.cpp 95% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72da9ac...26fe011. Read the comment docs.

jngrad
jngrad approved these changes Sep 5, 2019
View reviewed changes
Copy link
Member

@jngrad jngrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jngrad
Copy link
Member

jngrad commented Sep 6, 2019

bors r+

bors bot added a commit that referenced this pull request Sep 6, 2019
@bors @reinaual
Merge #3123
6c7bc5a 
3123: ELC Coverage, integer flags converted r=jngrad a=reinaual

Should fix #2685 for the neutral case.
Also converted integer flags to boolean in ELC and MMM2D.




Co-authored-by: Alexander Reinauer <st144434@stud.uni-stuttgart.de>
@bors
Copy link
Contributor

bors bot commented Sep 6, 2019

Build succeeded

@bors bors bot merged commit 26fe011 into espressomd:python Sep 6, 2019
@reinaual reinaual deleted the ELCCoverage branch September 6, 2019 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jngrad jngrad jngrad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Identify (and resolve) missing coverage for ELC
2 participants
@reinaual @jngrad