Particle data cleanup #3232
Merged
Particle data cleanup #3232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaiSzuttor
approved these changes
Oct 4, 2019
Codecov Report
@@ Coverage Diff @@
## python #3232 +/- ##
=======================================
+ Coverage 85% 85% +<1%
=======================================
Files 528 528
Lines 25805 25800 -5
=======================================
- Hits 22150 22147 -3
+ Misses 3655 3653 -2
Continue to review full report at Codecov.
|
|
bors r=KaiSzuttor |
bors bot
added a commit
that referenced
this pull request
Oct 11, 2019
3212: Remove unused force reduction function r=fweik a=hirschsn The function `reduce_forces_sum` was made obsolete by a538ebb Fixes # Description of changes: - Remove unused function PR Checklist ------------ - [ ] Tests? - [ ] Interface - [ ] Core - [ ] Docs? 3221: Make unit tests respect Cmake MPIEXEC_*FLAGS r=jngrad a=hirschsn There are two cmake flags called MPIEXEC_PREFLAGS and MPIEXEC_POSTFLAGS. This commit makes the unit test include these two variables in the creation of the cmdlines. These variables are useful for passing parameters to mpiexec, e.g. MPIEXEC_PREFLAGS="--bind-to;none". Fixes # Description of changes: - PR Checklist ------------ - [ ] Tests? - [ ] Interface - [ ] Core - [ ] Docs? 3232: Particle data cleanup r=KaiSzuttor a=fweik Description of changes: - Removed unused functions and macro 3240: Benchmark: Ferrofluid benchmark (derived from LJ one) r=fweik a=RudolfWeeber I did not include it into the benchmark cmake target, as it is not such a common scenario outside the ICP Co-authored-by: Steffen Hirschmann <steffen.hirschmann@ipvs.uni-stuttgart.de> Co-authored-by: Florian Weik <fweik@icp.uni-stuttgart.de> Co-authored-by: Rudolf Weeber <weeber@icp.uni-stuttgart.de>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: