Fix cmake install on dev branch #3248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installing ESPResSo with `make install DESTDIR="/path/to/es"` will install files in the wrong folder and set an incorrect runtime path in Cython shared objects, causing import errors. See full report: espressomd#3228 (comment)
When installing ESPResSo, the C++ shared objects and Cython shared objects are stored in the same folder. Since they have the same .so extension, when importing espressomd.cluster_analysis, the file cluster_analysis.py is loaded and the file cluster_analysis.so is automatically considered a Cython shared object, and Python fails to find the Cython-specific symbol PyInit_cluster_analysis. This is remediated by giving a different name to the C++ shared object.
Install the files in a different directory and check the python and tutorials/samples tests can still run with the installed files. Please note that pypresso will experience a major slowdown in CI when located outside the build directory, hence the 3h timeout. This job is meant to be run only during releases and in PRs that add new core modules.
Takes more than 1 hour to run in CI when pypresso is located outside the build directory.
Codecov Report
@@ Coverage Diff @@
## python #3248 +/- ##
======================================
- Coverage 85% 85% -1%
======================================
Files 530 528 -2
Lines 25795 25790 -5
======================================
- Hits 22168 22146 -22
- Misses 3627 3644 +17
Continue to review full report at Codecov.
|
The installed files only exist if the Python bindings are enabled.
jngrad
force-pushed
the
fix-cmake-install-dev
branch
from
4d92d88
to
103a27d
Compare
The clang:6.0 job fails due to undefined ASAN symbols. The logic to fix that error is in the pypresso wrapper.
|
bors r=KaiSzuttor |
bors bot
added a commit
that referenced
this pull request
Oct 15, 2019
3248: Fix cmake install on dev branch r=KaiSzuttor a=jngrad Porting #3228 to the dev branch Description of changes: - fix the CMake build system to include libraries in the list of installed files and test it in a dedicated CI job - fix the versioning of Cython .so shared objects - simplify the CMake tests 3251: Particle data r=jngrad a=fweik Fixes #3157. Description of changes: - Split definition of `struct Particle` from rest of particle data. Co-authored-by: Christoph Junghans <junghans@lanl.gov> Co-authored-by: Jean-Noël Grad <jgrad@icp.uni-stuttgart.de> Co-authored-by: Florian Weik <fweik@icp.uni-stuttgart.de>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting #3228 to the dev branch
Description of changes: