LB Boundary force: fix unit conversion and tests #3287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference solutions for forces on shear planes and for stokes drag need dynamic viscosity, but LB uses kinetmatic viscosity. This switches the tests to dynamic viscosity and removes a 1/rho from the unit conversion in the script interface. Also, a force balance test is added, which does not depend on the density.
Codecov Report
@@ Coverage Diff @@
## python #3287 +/- ##
======================================
- Coverage 85% 85% -1%
======================================
Files 534 534
Lines 25526 25524 -2
======================================
- Hits 21950 21948 -2
Misses 3576 3576
Continue to review full report at Codecov.
|
fweik
reviewed
Oct 31, 2019
fweik
approved these changes
Oct 31, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 31, 2019
3287: LB Boundary force: fix unit conversion and tests r=fweik a=RudolfWeeber Reference solutions for forces on shear planes and for stokes drag need dynamic viscosity, but LB uses kinetmatic viscosity. This switches the tests to dynamic viscosity and removes a 1/rho from the unit conversion in the script interface. Also, a force balance test is added, which does not depend on the density. Fixes # Description of changes: - PR Checklist ------------ - [ ] Tests? - [ ] Interface - [ ] Core - [ ] Docs? Co-authored-by: Rudolf Weeber <weeber@icp.uni-stuttgart.de>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference solutions for forces on shear planes and for stokes drag need dynamic viscosity, but LB uses kinetmatic viscosity.
This switches the tests to dynamic viscosity and removes a 1/rho from the unit conversion in the script interface.
Also, a force balance test is added, which does not depend on the density.
Fixes #
Description of changes:
PR Checklist