fix writevtk() bug where types=all was ignored #3290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jngrad
requested changes
Oct 31, 2019
Codecov Report
@@ Coverage Diff @@
## python #3290 +/- ##
=======================================
+ Coverage 85% 85% +<1%
=======================================
Files 534 534
Lines 25524 25524
=======================================
+ Hits 21948 21949 +1
+ Misses 3576 3575 -1
Continue to review full report at Codecov.
|
switch conditionals as suggested by JNGrad Co-Authored-By: Jean-Noël Grad <jgrad@icp.uni-stuttgart.de>
jngrad
approved these changes
Oct 31, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 31, 2019
3288: core: Simplify particle removal r=RudolfWeeber a=fweik Fixes #3286. Description of changes: - Simplify particle removal by doing one linear pass over all particles instead using index 3290: fix writevtk() bug where types=all was ignored r=jngrad a=christophlohrmann Description of changes: - fixed bug where the argument ``types='all'`` was ignored by ``system.part.writevtk()`` PR Checklist ------------ - [ ] Tests? - [ ] Interface - [ ] Core - [ ] Docs? Co-authored-by: Florian Weik <fweik@icp.uni-stuttgart.de> Co-authored-by: Christoph Lohrmann <clohrmann@icp.uni-stuttgart.de> Co-authored-by: christophlohrmann <47663906+christophlohrmann@users.noreply.github.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
types='all'was ignored bysystem.part.writevtk()PR Checklist