Pypresso: Remove "test -a" and quote $@ #3292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
POSIX does not specify test for > 4 arguments: https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html
Codecov Report
@@ Coverage Diff @@
## python #3292 +/- ##
=======================================
+ Coverage 85% 86% +<1%
=======================================
Files 534 534
Lines 25510 25510
=======================================
+ Hits 21937 21939 +2
+ Misses 3573 3571 -2
Continue to review full report at Codecov.
|
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 4, 2019
3291: Factor out and test memcpy serialization r=RudolfWeeber a=fweik Description of changes: - This splits off the memcpy serialization used in the ghost communication and adds unit test for it. - Added customization point to opt-in to memcpy serialization for types that are not [TriviallyCopyable](https://en.cppreference.com/w/cpp/named_req/TriviallyCopyable), but serializes to a bounded size, like `boost::optional`. This is so we can use `optional` and `variant` in `ParticleProperties`, which is planned. 3292: Pypresso: Remove "test -a" and quote $@ r=jngrad a=hirschsn Description of changes: - Remove `test -a` since calls to test with more than 4 arguments are unspecified: https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html - Quote `$@` to avoid splitting $@. Currently `./pypresso --gdb "test me.py"` will fail because tries to find the file `test`. Quoting avoids this. PR Checklist ------------ - [ ] Tests? - [ ] Interface - [ ] Core - [ ] Docs? Co-authored-by: Florian Weik <fweik@icp.uni-stuttgart.de> Co-authored-by: Steffen Hirschmann <steffen.hirschmann@ipvs.uni-stuttgart.de>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
test -asince calls to test with more than 4 arguments are unspecified: https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html$@to avoid splitting $@. Currently./pypresso --gdb "test me.py"will fail because tries to find the filetest. Quoting avoids this.PR Checklist