Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warning on empty config with GPU #3329

Merged
merged 2 commits into from
Nov 19, 2019

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Nov 19, 2019

No description provided.

Fix the following nvcc compiler warning on empty myconfig:
`src/core/grid_based_algorithms/lbgpu_cuda.cu(95): warning: variable
"lb_boundary_force" was declared but never referenced`
@jngrad jngrad added this to the 4.1.2 milestone Nov 19, 2019
@codecov
Copy link

codecov bot commented Nov 19, 2019

Codecov Report

Merging #3329 into python will increase coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           python   #3329    +/-   ##
=======================================
+ Coverage      86%     86%   +<1%     
=======================================
  Files         538     538            
  Lines       25346   25346            
=======================================
+ Hits        21830   21831     +1     
+ Misses       3516    3515     -1
Impacted Files Coverage Δ
src/core/particle_data.cpp 97% <0%> (-1%) ⬇️
src/core/electrostatics_magnetostatics/p3m.cpp 85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f232261...b8fa366. Read the comment docs.

@jngrad jngrad requested a review from fweik November 19, 2019 18:41
@fweik
Copy link
Contributor

fweik commented Nov 19, 2019

Warnings are still not errors in CUDA...

@fweik
Copy link
Contributor

fweik commented Nov 19, 2019

bors r+

bors bot added a commit that referenced this pull request Nov 19, 2019
3329: Fix compiler warning on empty config with GPU r=fweik a=jngrad



Co-authored-by: Jean-Noël Grad <jgrad@icp.uni-stuttgart.de>
@bors
Copy link
Contributor

bors bot commented Nov 19, 2019

Build succeeded

@bors bors bot merged commit b8fa366 into espressomd:python Nov 19, 2019
@mkuron
Copy link
Member

mkuron commented Nov 19, 2019

Warnings are still not errors in CUDA...

Correct, nvcc does not have a -Werror flag.

@jngrad jngrad deleted the fix-lb-var-empty-config branch January 18, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants