Structure mc documentation #3330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the correct description would be
the particles are no longer numbered contiguously?
Iterators along the lines of
for p in system.part:
....
would still work, wouldn.t they?
|
|
Yes iterating across system.part would work, also iterating over valid pids (given in system.part.id) would work. |
Codecov Report
@@ Coverage Diff @@
## python #3330 +/- ##
=======================================
+ Coverage 86% 86% +<1%
=======================================
Files 538 538
Lines 25350 25350
=======================================
+ Hits 21834 21835 +1
+ Misses 3516 3515 -1
Continue to review full report at Codecov.
|
Move links to scripts and classes after the algorithm descriptions. Provide a link to the class instead of a link to the module. Remove outdated comments. Discuss particle ordering after a reaction step.
jngrad
force-pushed
the
structure_MC_documentation
branch
from
777b6ce
to
a2ff806
Compare
jngrad
approved these changes
Nov 22, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 22, 2019
3330: Structure mc documentation r=jngrad a=jonaslandsgesell Fixes #3309 * correctly indent the Reaction Ensemble subsections in the Sphinx docs * add a note explaining particle ids may be invalidated when a chemical reaction is added 3332: Add 4.1.1 release notes in master r=fweik a=jngrad Co-authored-by: Jonas Landsgesell <jonaslandsgesell@users.noreply.github.com> Co-authored-by: Jean-Noël Grad <jgrad@icp.uni-stuttgart.de>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3309