Fix breaking tests on 4.1.1 #3358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The P3M benchmark test is fragile and breaks regularly in CI, but only in tutorial-sample jobs. Multiple attempts at fixing the tuning function did not resolve the issue. Disabling the test for now.
This test fails on openSUSE Tumbleweed i586 due to precision error.
fweik
approved these changes
Dec 5, 2019
Codecov Report
@@ Coverage Diff @@
## python #3358 +/- ##
=======================================
+ Coverage 86% 86% +<1%
=======================================
Files 537 537
Lines 25283 25283
=======================================
+ Hits 21754 21755 +1
+ Misses 3529 3528 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
field_coupling_fieldsfor i586 builds (partial fix for espresso-v4.1.1: MpiCallbacks_test and matrix_vector_product fail on i586 (OpenSuse Tumbleweed) #3315)