Fix particle-id based observables with non-contigeous particle numbering #3380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RudolfWeeber
force-pushed
the
pid_observables_fix
branch
from
9d6a5a1
to
e1fd461
Compare
Codecov Report
@@ Coverage Diff @@
## python #3380 +/- ##
=======================================
+ Coverage 86% 86% +<1%
=======================================
Files 537 537
Lines 25283 25285 +2
=======================================
+ Hits 21805 21808 +3
+ Misses 3478 3477 -1
Continue to review full report at Codecov.
|
|
bors r=jngrad p=1910603306 |
bors bot
added a commit
that referenced
this pull request
Dec 12, 2019
3380: Fix particle-id based observables with non-contigeous particle numbering r=jngrad a=RudolfWeeber Fixes #3362 * Fixes some pid obervables which were using the index in the list of particle ids rather than the particle id. * Test pid-based observables with non-contigeous particle ids * Remove the mass prefactors from ComForce, so that it calculates what is claimed i the docstring. I did not rename ComForce, since this is for a bugfix release. Later it should become TotalForce. Co-authored-by: Rudolf Weeber <weeber@icp.uni-stuttgart.de>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3362
I did not rename ComForce, since this is for a bugfix release. Later it should become TotalForce.