Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Boost tests #3427

Merged
merged 1 commit into from
Jan 21, 2020
Merged

Fix Boost tests #3427

merged 1 commit into from
Jan 21, 2020

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Jan 21, 2020

Fixes #3426

`BOOST_*_CLOSE` assertions take a tolerance as a percentage.
When using machine epsilon, it needs to be multiplied by 100.
@jngrad jngrad added this to the Espresso 4.1.3 milestone Jan 21, 2020
@jngrad jngrad requested a review from fweik January 21, 2020 14:43
@codecov
Copy link

codecov bot commented Jan 21, 2020

Codecov Report

Merging #3427 into python will decrease coverage by <1%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           python   #3427   +/-   ##
======================================
- Coverage      86%     86%   -1%     
======================================
  Files         534     534           
  Lines       25099   25099           
======================================
- Hits        21703   21702    -1     
- Misses       3396    3397    +1
Impacted Files Coverage Δ
src/utils/tests/matrix_vector_product.cpp 100% <ø> (ø) ⬆️
src/core/unit_tests/grid_test.cpp 100% <100%> (ø) ⬆️
src/utils/tests/interpolation_test.cpp 100% <100%> (ø) ⬆️
src/utils/tests/int_pow_test.cpp 100% <100%> (ø) ⬆️
src/core/observables/ComForce.hpp 91% <0%> (-9%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d553bd5...540b6f0. Read the comment docs.

@jngrad
Copy link
Member Author

jngrad commented Jan 21, 2020

@junghans I've tried cherry-picking this PR locally on top of 4.1.2 and it merged cleanly. You should be able to use it directly in 4.1.2 builds, without an if condition on i586 (the tests were wrong for all archs).

@junghans
Copy link
Member

Seems to work! collision_detection still fails reliably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Boost tests
3 participants