Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bond cutoff #3443

Merged
merged 2 commits into from
Jan 30, 2020
Merged

Bond cutoff #3443

merged 2 commits into from
Jan 30, 2020

Conversation

fweik
Copy link
Contributor

@fweik fweik commented Jan 30, 2020

Fixes #3442

Description of changes:

  • Define and consider cutoff for all bond types.

@fweik fweik added this to the Espresso 4.1.3 milestone Jan 30, 2020
@fweik fweik requested a review from jngrad January 30, 2020 15:25
@codecov
Copy link

codecov bot commented Jan 30, 2020 •
edited
Loading

Codecov Report

Merging #3443 into python will decrease coverage by <1%.
The diff coverage is 90%.

Impacted file tree graph

@@          Coverage Diff           @@
##           python   #3443   +/-   ##
======================================
- Coverage      86%     86%   -1%     
======================================
  Files         537     537           
  Lines       25466   25473    +7     
======================================
+ Hits        22083   22087    +4     
- Misses       3383    3386    +3
Impacted Files Coverage Δ
src/core/bonded_interactions/bonded_tab.cpp 91% <100%> (ø) ⬆️
...re/bonded_interactions/bonded_interaction_data.hpp 100% <100%> (ø) ⬆️
...re/bonded_interactions/bonded_interaction_data.cpp 91% <86%> (-9%) ⬇️
src/core/particle_data.cpp 97% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 846690f...a757875. Read the comment docs.

jngrad
jngrad approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@jngrad jngrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fweik fweik added the automerge Merge with kodiak label Jan 30, 2020
@kodiakhq kodiakhq bot merged commit 780c7fd into espressomd:python Jan 30, 2020
@fweik fweik deleted the bond_cutoff branch August 27, 2020 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jngrad jngrad jngrad approved these changes

Assignees
No one assigned
Labels
automerge Merge with kodiak BugFix Core
Projects
None yet
Milestone
Espresso 4.1.3
Development

Successfully merging this pull request may close these issues.

Not all bond type considered for cutoff calculation
2 participants
@fweik @jngrad