Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sphinx: fix code samples (instantiation and naming of System()) #3542

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

pkreissl
Copy link
Contributor

Description of changes:

  • lb.rst contained outdated code for instantiating the System-class, namely missing the mandatory box_l parameter, only trying to set it afterwards.
  • Fixed that there and in all other places that I found via a quick search.
  • While at it, I renamed the occurrences of instances of System that were not called system, to match the naming convention of consistent style in samples #1845.

@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #3542 into python will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           python   #3542   +/-   ##
======================================
  Coverage      87%     87%           
======================================
  Files         536     536           
  Lines       24177   24177           
======================================
  Hits        21056   21056           
  Misses       3121    3121
Impacted Files Coverage Δ
src/core/particle_data.cpp 94% <0%> (-1%) ⬇️
src/core/electrostatics_magnetostatics/p3m.cpp 85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc4a9cc...9620c90. Read the comment docs.

@jngrad jngrad added this to the Espresso 4.1.3 milestone Feb 25, 2020
@jngrad jngrad changed the title Spinx: fix code samples (instantiation and naming of System()) Sphinx: fix code samples (instantiation and naming of System()) Feb 25, 2020
@jngrad jngrad added the automerge Merge with kodiak label Feb 25, 2020
@kodiakhq kodiakhq bot merged commit 50ec583 into espressomd:python Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants