Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning from collections.abc #3568

Merged
merged 1 commit into from
Mar 9, 2020

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Mar 9, 2020

Fix a deprecation warning that will break espresso in Python 3.9.

DeprecationWarning: Using or importing the ABCs from 'collections'
instead of from 'collections.abc' is deprecated since Python 3.3,
and in 3.9 it will stop working.
@jngrad jngrad added this to the Espresso 4.1.3 milestone Mar 9, 2020
@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #3568 into python will increase coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           python   #3568    +/-   ##
=======================================
+ Coverage      88%     88%   +<1%     
=======================================
  Files         524     524            
  Lines       23598   23598            
=======================================
+ Hits        20772   20773     +1     
+ Misses       2826    2825     -1
Impacted Files Coverage Δ
src/core/particle_data.cpp 95% <0%> (-1%) ⬇️
src/core/polymer.cpp 98% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 729a677...ae08014. Read the comment docs.

@jngrad jngrad requested a review from fweik March 9, 2020 15:55
@jngrad
Copy link
Member Author

jngrad commented Mar 9, 2020

@junghans I've seen Fedora is testing all packages against early pre-releases of Python 3.9. You might need to add that patch to the espresso 4.1.2 specfile once the MPICH issue in Bugzilla 1793563 is resolved.

@junghans
Copy link
Member

junghans commented Mar 9, 2020

@jngrad thanks!

@jngrad jngrad added the automerge Merge with kodiak label Mar 9, 2020
@kodiakhq kodiakhq bot merged commit 19a0b9c into espressomd:python Mar 9, 2020
@jngrad jngrad deleted the fix-abc-deprecate branch January 18, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants