Refactor CMake package inclusion #3574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The feature is not longer required, and actually has compatibility issues with CUDA 10.1 (e.g. `CUDA_cublas_device_LIBRARY-NOTFOUND`). From the CMake 3.10 documentation: ["The FindCUDA module has been superseded by first-class support for the CUDA language in CMake. It is no longer necessary to use this module or call `find_package(CUDA)`. This module now exists only for compatibility with projects that have not been ported."]( https://cmake.org/cmake/help/v3.10/module/FindCUDA.html)
Co-authored-by: Jean-Noël Grad <jgrad@icp.uni-stuttgart.de>
The Cython version is already written to the output of CMake 3.10+.
The CMake check ignored the Cython version passed as argument to the `find_package()` function.
The NumPy version is already written to the output of CMake 3.10+.
Break Python/Cython cyclic dependency and re-use values from the first call to `find_package(PythonInterp 3.5 REQUIRED)` instead of calling the function again without the correct version.
Codecov Report
@@ Coverage Diff @@
## python #3574 +/- ##
======================================
- Coverage 88% 88% -1%
======================================
Files 524 524
Lines 23599 23599
======================================
- Hits 20776 20775 -1
- Misses 2823 2824 +1
Continue to review full report at Codecov.
|
jngrad
changed the title
|
@KaiSzuttor here is a draft of the next PR where we split the CUDA compiler detection mechanism in separate files: jngrad/espresso:refactor-cmake-with_gpu |
KaiSzuttor
reviewed
Mar 12, 2020
KaiSzuttor
approved these changes
Mar 12, 2020
just open a draft PR, LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
CMakeLists.txtto dedicated helper filescmake/Find<package>.cmakeforfind_package()CMakeLists.txtWITH_CUDAis set to true but no CUDA-capable compiler is foundWITH_CLANG_TIDYis set to true but Clang-tidy is not found or its version doesn't match the Clang compiler versionFindCUDAin favor of native CUDA support in CMake 3.10 (required for WIP: Stokesian Dynamics #3445)