Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: p3m: Assert that interpolation is inside the local mesh patch. #3715

Merged
merged 1 commit into from
May 15, 2020
Merged

core: p3m: Assert that interpolation is inside the local mesh patch. #3715

merged 1 commit into from
May 15, 2020

Conversation

fweik
Copy link
Contributor

@fweik fweik commented May 15, 2020 •
edited
Loading

Description of changes:

  • Assert that points are in the locale mesh patch in p3m interpolation.

@codecov
Copy link

codecov bot commented May 15, 2020 •
edited
Loading

Codecov Report

Merging #3715 into python will decrease coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           python   #3715   +/-   ##
======================================
- Coverage      88%     88%   -1%     
======================================
  Files         545     545           
  Lines       24718   24720    +2     
======================================
- Hits        21784   21781    -3     
- Misses       2934    2939    +5
Impacted Files Coverage Δ
...lectrostatics_magnetostatics/p3m_interpolation.hpp 100% <100%> (ø)
src/core/polymer.cpp 92% <0%> (-7%) ⬇️
src/utils/include/utils/Vector.hpp 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d8e7a5...75aa3b4. Read the comment docs.

@fweik fweik requested a review from jngrad May 15, 2020 08:09
@fweik fweik changed the title WIP: core: p3m: Assert that interpolation is inside the local mesh patch. core: p3m: Assert that interpolation is inside the local mesh patch. May 15, 2020
@jngrad jngrad added this to the Espresso 4.2 milestone May 15, 2020
@jngrad jngrad added the automerge Merge with kodiak label May 15, 2020
@kodiakhq kodiakhq bot merged commit f6df110 into espressomd:python May 15, 2020
@jngrad jngrad mentioned this pull request May 15, 2020
Closed
@jngrad jngrad removed this from the Espresso 4.2 milestone May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jngrad jngrad jngrad approved these changes

Assignees
No one assigned
Labels
automerge Merge with kodiak Core Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fweik @jngrad