Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Variant bug in pack_pair() #3725

Merged
merged 1 commit into from
May 22, 2020
Merged

Fix Variant bug in pack_pair() #3725

merged 1 commit into from
May 22, 2020

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented May 22, 2020

Fixes #3711

@jngrad jngrad added the BugFix label May 22, 2020
@jngrad jngrad added this to the Espresso 4.1.3 milestone May 22, 2020
@jngrad jngrad requested a review from fweik May 22, 2020 15:24
@codecov
Copy link

codecov bot commented May 22, 2020 •
edited
Loading

Codecov Report

Merging #3725 into python will decrease coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           python   #3725   +/-   ##
======================================
- Coverage      88%     88%   -1%     
======================================
  Files         549     549           
  Lines       24685   24685           
======================================
- Hits        21755   21750    -5     
- Misses       2930    2935    +5
Impacted Files Coverage Δ
src/script_interface/Variant.hpp 100% <100%> (ø)
src/core/polymer.cpp 92% <0%> (-7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e578cd...48f0423. Read the comment docs.

@jngrad
Copy link
Member Author

jngrad commented May 22, 2020

@junghans You'll most likely need this patch to build espressomd 4.1.2 on the upcoming Fedora 33. It merges cleanly (backported in 4.1.3 as f1286e4).

@jngrad jngrad added the automerge Merge with kodiak label May 22, 2020
@kodiakhq kodiakhq bot merged commit cb2385f into espressomd:python May 22, 2020
@jngrad jngrad mentioned this pull request Jun 5, 2020
Closed
@jngrad jngrad deleted the fix-boost173-variant branch January 18, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fweik fweik fweik approved these changes

Assignees
No one assigned
Labels
automerge Merge with kodiak BugFix
Projects
None yet
Milestone
Espresso 4.1.3
Development

Successfully merging this pull request may close these issues.

Variant_test fails with boost 1.73.0
2 participants
@jngrad @fweik