missing coulomb prefactors in ELCIC #3731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah thank you. I missed that the ELC energy is added on a different path. |
fweik
approved these changes
May 25, 2020
Codecov Report
@@ Coverage Diff @@
## python #3731 +/- ##
======================================
Coverage 88% 88%
======================================
Files 551 551
Lines 24669 24669
======================================
+ Hits 21771 21781 +10
+ Misses 2898 2888 -10
Continue to review full report at Codecov.
|
kodiakhq bot
added a commit
that referenced
this pull request
May 26, 2020
in #3731 i introduced a violation of the charge free space_layer by the second particle in the testcase. Numerically this is not a problem because the dielectric constrast in this space layer was set to zero.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3722