Build system: fail when explicitly requested optional dependencies are not found #3735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate an error when an explicitly requested optional dependency is not found instead of silently carrying on. This is achieved by creating a wrapper around the `option()` function to check whether the user explicitly passed a CMake flag `-DWITH_FEATURE=ON`.
fweik
previously approved these changes
May 27, 2020
Codecov Report
@@ Coverage Diff @@
## python #3735 +/- ##
======================================
- Coverage 89% 89% -1%
======================================
Files 548 548
Lines 24455 24431 -24
======================================
- Hits 21779 21756 -23
+ Misses 2676 2675 -1
Continue to review full report at Codecov.
|
mkuron
previously approved these changes
May 27, 2020
RudolfWeeber
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #3656
Provide meaningful error messages when optional dependencies (HDF5, GSL, ScaFaCoS) are specifically requested by the user with
-DWITH_FEATURE=ONbut not found on the system.